fix: 默认值没有添加上单位, 点击事件阻止冒泡 #9204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurunze1226
suggested changes
Dec 21, 2023
| @@ -213,6 +213,10 @@ export default class NumberControl extends React.Component< | |||
| } | |||
|
|
|||
| this.state = {unit, unitOptions}; | |||
|
|
|||
| if (unit && value != null) { | |||
| setPrinstineValue(this.getValue(value)); | |||
gooolh
force-pushed
the
fix-input-number
branch
2 times, most recently
from
77dbabb to
3605cdd
Compare
lurunze1226
suggested changes
Dec 21, 2023
|
|
||
| const staticDom = container.querySelector('.cxd-PlainField') as Element; | ||
|
|
||
| expect(staticDom.innerHTML).toBe('<span class="text-muted">12px</span>'); |
There was a problem hiding this comment.
这个判断innerText就够了，不需要关心DOM结构
| expect(staticDom.innerHTML).toBe('99px'); | ||
|
|
||
| replaceReactAriaIds(container); | ||
| expect(container).toMatchSnapshot(); |
There was a problem hiding this comment.
后面两行不需要，前面的逻辑检查足够了，不需要快照，测试单位的那个已经覆盖了
gooolh
force-pushed
the
fix-input-number
branch
2 times, most recently
from
726dd8f to
8ed8125
Compare
lurunze1226
approved these changes
Dec 21, 2023
2betop
reviewed
Dec 21, 2023
| @@ -213,6 +213,10 @@ export default class NumberControl extends React.Component< | |||
| } | |||
|
|
|||
| this.state = {unit, unitOptions}; | |||
|
|
|||
| if (unit && value != null) { | |||
| setPrinstineValue(this.getValue(value)); | |||
There was a problem hiding this comment.
如果 value 和 this.getValue(value) 结果一样呢？是不是不应该触发？
|
请补充这个场景用例 form 配置 initApi，初始不带单位，通过按钮点击后，重新拉取 initApi，也没有带单位，不修改直接提交，这个数值预期应该是要带单位的。 |
gooolh
force-pushed
the
fix-input-number
branch
3 times, most recently
from
c746d08 to
521fde3
Compare
gooolh
force-pushed
the
fix-input-number
branch
from
521fde3 to
d2644f8
Compare
hsm-lv
approved these changes
Dec 22, 2023
2betop
reviewed
Dec 25, 2023
| unit && | ||
| !String(value).endsWith(unit) | ||
| ) { | ||
| this.props.setPrinstineValue(this.getValue(value)); |
There was a problem hiding this comment.
初步感觉有两个问题
- didMount 没有相关逻辑
- 如果 外部 value 发生变化，而且初始化之后，不应该是 setPrinstineValue 而是 onChange出去
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
默认值未处理单位
阻止冒泡事件
How